Fix #886: use default instead of null for optional struct ByRef parameters#1253
Open
GrahamTheCoder wants to merge 2 commits intoicsharpcode:masterfrom
Open
Conversation
…al ByRef struct params When a VB method has an optional ByRef struct (value type) parameter with Nothing as the default, the converter previously generated `null` as the initializer for the hoisted local variable. `null` is not valid for value types in C#, causing a compilation error. The fix introduces a `LiteralOrDefault` helper that returns the `default` literal when the parameter type is a value type and the explicit default value is null. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
GrahamTheCoder
force-pushed
the
claude/fix-issue-886-optional-struct-ref
branch
from
ff3cc72 to
c118125
Compare
…n Vsix not built The Vsix project uses UseWPF=true with net472, which fails SDK validation when MSBuild tries to build it as a dependency of Tests.csproj on newer .NET SDK versions. Setting Build="false" prevents this. Also makes the VsixDoesNotReferenceNewerBclPolyfillsThanOldestSupportedVs test skip gracefully when the Vsix output directory is absent (matching the second test). https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #886
When a VB optional ByRef parameter has a struct type with
Nothingas default, Roslyn returns null from ExplicitDefaultValue. Generating a null literal causes a C# compile error since structs cannot be null. Usedefaultinstead when the parameter type is a value type and the default value is null.https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX